From cbda103fd9ae50679131a8bea30611543dfd0aec Mon Sep 17 00:00:00 2001
From: Gregory Wells <me@gregorywells.dev>
Date: Wed, 9 Jul 2025 16:45:16 -0400
Subject: [PATCH] fix some buffer stuff or smt

---
 .../apis/vulkan/src/buffers/vulkan_buffer.c   |  4 +---
 .../output_device/vulkan_physical_device.c    | 19 +++++++++----------
 .../gryphn_physical_output_device.h           |  2 +-
 3 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/projects/apis/vulkan/src/buffers/vulkan_buffer.c b/projects/apis/vulkan/src/buffers/vulkan_buffer.c
index 5f41969..1528c9d 100644
--- a/projects/apis/vulkan/src/buffers/vulkan_buffer.c
+++ b/projects/apis/vulkan/src/buffers/vulkan_buffer.c
@@ -101,10 +101,9 @@ void vulkanBufferSubData(gnBufferHandle buffer, size_t offset, size_t dataSize,
     if (buffer->buffer->useStagingBuffer) {
         VkGryphnBuffer* stagingBuffer = &buffer->device->outputDevice->stagingBuffer;
         VkDeviceSize sizeLeft = dataSize;
-        int copies = 0;
         while (sizeLeft > 0) {
             VkDeviceSize chunkSize = (buffer->device->outputDevice->stagingBufferSize < sizeLeft) ? buffer->device->outputDevice->stagingBufferSize : sizeLeft;
-            vkMapMemory(buffer->device->outputDevice->device, stagingBuffer->memory, 0, dataSize, 0, &bufferData);
+            vkMapMemory(buffer->device->outputDevice->device, stagingBuffer->memory, 0, chunkSize, 0, &bufferData);
             memcpy(bufferData, data + (dataSize - sizeLeft), chunkSize);
             vkUnmapMemory(buffer->device->outputDevice->device, stagingBuffer->memory);
 
@@ -115,7 +114,6 @@ void vulkanBufferSubData(gnBufferHandle buffer, size_t offset, size_t dataSize,
             };
             VkCopyBuffer(buffer->device, stagingBuffer->buffer, buffer->buffer->buffer.buffer, copyRegion);
             sizeLeft -= chunkSize;
-            copies++;
         }
     } else {
         vkMapMemory(buffer->device->outputDevice->device, buffer->buffer->buffer.memory, 0, dataSize, 0, &bufferData);
diff --git a/projects/apis/vulkan/src/output_device/vulkan_physical_device.c b/projects/apis/vulkan/src/output_device/vulkan_physical_device.c
index ffea1c3..5545f7b 100644
--- a/projects/apis/vulkan/src/output_device/vulkan_physical_device.c
+++ b/projects/apis/vulkan/src/output_device/vulkan_physical_device.c
@@ -5,13 +5,13 @@
 
 gnMultisampleCountFlags vkSampleCountToGryphn(VkSampleCountFlags counts) {
     gnMultisampleCountFlags sampleCount = 0;
-    if (counts & VK_SAMPLE_COUNT_64_BIT) { sampleCount |= GN_SAMPLE_BIT_64; }
-    if (counts & VK_SAMPLE_COUNT_32_BIT) { sampleCount |= GN_SAMPLE_BIT_32; }
-    if (counts & VK_SAMPLE_COUNT_16_BIT) { sampleCount |= GN_SAMPLE_BIT_16; }
-    if (counts & VK_SAMPLE_COUNT_8_BIT) { sampleCount |= GN_SAMPLE_BIT_8; }
-    if (counts & VK_SAMPLE_COUNT_4_BIT) { sampleCount |= GN_SAMPLE_BIT_4; }
-    if (counts & VK_SAMPLE_COUNT_2_BIT) { sampleCount |= GN_SAMPLE_BIT_2; }
-    if (counts & VK_SAMPLE_COUNT_1_BIT) { sampleCount |= GN_SAMPLE_BIT_1; }
+    if ((counts & VK_SAMPLE_COUNT_64_BIT) == VK_SAMPLE_COUNT_64_BIT) { sampleCount |= GN_SAMPLE_BIT_64; }
+    if ((counts & VK_SAMPLE_COUNT_32_BIT) == VK_SAMPLE_COUNT_32_BIT) { sampleCount |= GN_SAMPLE_BIT_32; }
+    if ((counts & VK_SAMPLE_COUNT_16_BIT) == VK_SAMPLE_COUNT_16_BIT) { sampleCount |= GN_SAMPLE_BIT_16; }
+    if ((counts & VK_SAMPLE_COUNT_8_BIT) == VK_SAMPLE_COUNT_8_BIT) { sampleCount |= GN_SAMPLE_BIT_8; }
+    if ((counts & VK_SAMPLE_COUNT_4_BIT) == VK_SAMPLE_COUNT_4_BIT) { sampleCount |= GN_SAMPLE_BIT_4; }
+    if ((counts & VK_SAMPLE_COUNT_2_BIT) == VK_SAMPLE_COUNT_2_BIT) { sampleCount |= GN_SAMPLE_BIT_2; }
+    if ((counts & VK_SAMPLE_COUNT_1_BIT) == VK_SAMPLE_COUNT_1_BIT) { sampleCount |= GN_SAMPLE_BIT_1; }
     return sampleCount;
 }
 
@@ -74,9 +74,8 @@ gnPhysicalDevice* getPhysicalDevices(gnInstanceHandle instance, uint32_t* device
 
         VkPhysicalDeviceProperties physicalDeviceProperties;
         vkGetPhysicalDeviceProperties(physicalDevices[i], &physicalDeviceProperties);
-        VkSampleCountFlags counts = physicalDeviceProperties.limits.framebufferColorSampleCounts & physicalDeviceProperties.limits.framebufferDepthSampleCounts;
-
-        outputDevices[i].features.avaliableSamples = vkSampleCountToGryphn(counts);
+        outputDevices[i].features.maxColorSamples = vkSampleCountToGryphn(physicalDeviceProperties.limits.framebufferColorSampleCounts);
+        outputDevices[i].features.maxDepthSamples = vkSampleCountToGryphn(physicalDeviceProperties.limits.framebufferDepthSampleCounts);
         outputDevices[i].features.maxMemoryAllocations = physicalDeviceProperties.limits.maxMemoryAllocationCount;
         outputDevices[i].features.maxPushConstantSize = physicalDeviceProperties.limits.maxPushConstantsSize;
     }
diff --git a/projects/core/src/output_device/gryphn_physical_output_device.h b/projects/core/src/output_device/gryphn_physical_output_device.h
index a455355..79c8f43 100644
--- a/projects/core/src/output_device/gryphn_physical_output_device.h
+++ b/projects/core/src/output_device/gryphn_physical_output_device.h
@@ -23,7 +23,7 @@ typedef struct gnPhysicalDeviceProperties {
 } gnPhysicalDeviceProperties;
 
 typedef struct gnPhysicalDeviceFeatures {
-    gnMultisampleCountFlags avaliableSamples;
+    gnMultisampleCountFlags maxColorSamples, maxDepthSamples;
     uint32_t maxMemoryAllocations;
     uint32_t maxPushConstantSize;
 } gnPhysicalDeviceFeatures;