removing commnets and also error checking
This commit is contained in:
@@ -32,36 +32,11 @@ bool checkValidationLayerSupport(gnList<gnString> layers_to_validate) {
|
||||
return true;
|
||||
}
|
||||
|
||||
// std::vector<const char*> getRequiredExtensions(bool validation_layers_required, gnInstance& instance) {
|
||||
// // uint32_t glfwExtensionCount = 0;
|
||||
// // const char** glfwExtensions;
|
||||
// // glfwExtensions = glfwGetRequiredInstanceExtensions(&glfwExtensionCount);
|
||||
|
||||
// std::vector<const char*> extensions(instance.instance->extensions, instance.instance->extensions + instance.instance->extensionCount);
|
||||
|
||||
// if (validation_layers_required) {
|
||||
// extensions.push_back(VK_EXT_DEBUG_UTILS_EXTENSION_NAME);
|
||||
// }
|
||||
|
||||
// #ifdef GN_PLATFORM_MACOS
|
||||
// extensions.push_back("VK_KHR_portability_enumeration");
|
||||
// extensions.push_back("VK_EXT_metal_surface");
|
||||
// #endif
|
||||
|
||||
// return extensions;
|
||||
// }
|
||||
|
||||
void gnInstanceSetAppInfoFn(gnInstance& instance, gnAppInfo& info) {
|
||||
if (instance.instance == nullptr) instance.instance = new gnPlatformInstanceData();
|
||||
|
||||
instance.AppInfo = info;
|
||||
instance.instance->appInfo = {};
|
||||
// instance.instance_data->appInfo.sType = VK_STRUCTURE_TYPE_APPLICATION_INFO;
|
||||
// instance.instance_data->appInfo.pApplicationName = gnToCString(info.ApplicationName);
|
||||
// instance.instance_data->appInfo.applicationVersion = info.ApplicationVersion;
|
||||
// instance.instance_data->appInfo.pEngineName = gnToCString(info.EngineName);
|
||||
// instance.instance_data->appInfo.engineVersion = info.EngineVersion;
|
||||
// instance.instance_data->appInfo.apiVersion = VK_API_VERSION_1_0; // fuck ass code idk what to do with it
|
||||
instance.instance->appInfo.sType = VK_STRUCTURE_TYPE_APPLICATION_INFO;
|
||||
instance.instance->appInfo.pApplicationName = "Hello Triangle";
|
||||
instance.instance->appInfo.applicationVersion = VK_MAKE_VERSION(1, 0, 0);
|
||||
|
@@ -11,7 +11,9 @@ GN_EXPORT gnReturnCode gnCreateX11WindowSurfaceFn(gnInstance& instance, Display*
|
||||
info.dpy = display;
|
||||
info.window = window;
|
||||
|
||||
vkCreateXlibSurfaceKHR(instance.instance->vk_instance, &info, nullptr, &instance.instance->window_surface);
|
||||
VkResult result = vkCreateXlibSurfaceKHR(instance.instance->vk_instance, &info, nullptr, &instance.instance->window_surface);
|
||||
if (result != VK_SUCCESS)
|
||||
return gnReturnError(GN_FAILED_CREATE_WINDOW_SURFACE, result);
|
||||
return GN_SUCCESS;
|
||||
}
|
||||
#endif
|
||||
@@ -26,7 +28,9 @@ GN_EXPORT gnReturnCode gnCreateWaylandWindowSurfaceFn(gnInstance& instance, wl_d
|
||||
info.surface = surface;
|
||||
|
||||
VkSurfaceKHR surface;
|
||||
vkCreateWaylandSurfaceKHR(instance.instance->vk_instance, &info, nullptr, &instance.instance->window_surface);
|
||||
VkResult result = vkCreateWaylandSurfaceKHR(instance.instance->vk_instance, &info, nullptr, &instance.instance->window_surface);
|
||||
if (result != VK_SUCCESS)
|
||||
return gnReturnError(GN_FAILED_CREATE_WINDOW_SURFACE, result);
|
||||
return GN_SUCCESS;
|
||||
}
|
||||
#endif
|
||||
@@ -41,11 +45,12 @@ GN_EXPORT gnReturnCode gnCreateWindowsWindowSurfaceFn(gnInstance& instance, HWND
|
||||
info.hinstance = instance;
|
||||
|
||||
VkSurfaceKHR surface;
|
||||
vkCreateWin32SurfaceKHR(instance.instance->vk_instance, &info, nullptr, &instance.instance->window_surface);
|
||||
VkResult result = vkCreateWin32SurfaceKHR(instance.instance->vk_instance, &info, nullptr, &instance.instance->window_surface);
|
||||
if (result != VK_SUCCESS)
|
||||
return gnReturnError(GN_FAILED_CREATE_WINDOW_SURFACE, result);
|
||||
return GN_SUCCESS;
|
||||
}
|
||||
#endif
|
||||
#include "vulkan/vulkan_macos.h"
|
||||
#include "vulkan/vulkan_metal.h"
|
||||
|
||||
#ifdef GN_PLATFORM_MACOS
|
||||
@@ -62,9 +67,8 @@ GN_EXPORT gnReturnCode gnCreateMacOSWindowSurfaceFn(gnInstance& instance, NS::Wi
|
||||
|
||||
VkSurfaceKHR surface;
|
||||
VkResult result = vkCreateMetalSurfaceEXT(instance.instance->vk_instance, &surfaceCreateInfo, nullptr, &instance.instance->window_surface);
|
||||
|
||||
// VkSurfaceKHR surface;
|
||||
// vkCreateMacOSSurfaceMVK(instance.instance->vk_instance, &info, nullptr, &instance.instance->window_surface);
|
||||
// return GN_SUCCESS;
|
||||
if (result != VK_SUCCESS)
|
||||
return gnReturnError(GN_FAILED_CREATE_WINDOW_SURFACE, result);
|
||||
return GN_SUCCESS;
|
||||
}
|
||||
#endif
|
||||
|
Reference in New Issue
Block a user