From 4e55fc672474ef3bdd8f0175619a8e02ae93c64f Mon Sep 17 00:00:00 2001 From: Gregory Wells Date: Sun, 3 Aug 2025 15:45:45 -0400 Subject: [PATCH] misses a couple vulkan warnings --- .../src/extensions/queues/vulkan_device_queues.c | 2 +- .../apis/vulkan/src/framebuffers/vulkan_framebuffer.c | 5 +++-- .../apis/vulkan/src/vulkan_surface/vulkan_surface.m | 11 ++++++----- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/projects/apis/vulkan/src/extensions/queues/vulkan_device_queues.c b/projects/apis/vulkan/src/extensions/queues/vulkan_device_queues.c index 870cb5d..454b682 100644 --- a/projects/apis/vulkan/src/extensions/queues/vulkan_device_queues.c +++ b/projects/apis/vulkan/src/extensions/queues/vulkan_device_queues.c @@ -8,7 +8,7 @@ gnReturnCode vulkanPhysicalDeviceQueueProperties(gnPhysicalOutputDeviceHandle de VkQueueFamilyProperties* queueFamilies = malloc(sizeof(VkQueueFamilyProperties) * queueFamilyCount); vkGetPhysicalDeviceQueueFamilyProperties(device->physicalDevice->device, &queueFamilyCount, queueFamilies); - for (int i = 0; i < queueFamilyCount; i++) { + for (uint32_t i = 0; i < queueFamilyCount; i++) { queues[i].queueCount = queueFamilies[i].queueCount; queues[i].queueTypeFlags = 0; diff --git a/projects/apis/vulkan/src/framebuffers/vulkan_framebuffer.c b/projects/apis/vulkan/src/framebuffers/vulkan_framebuffer.c index 8d9369c..c97dc54 100644 --- a/projects/apis/vulkan/src/framebuffers/vulkan_framebuffer.c +++ b/projects/apis/vulkan/src/framebuffers/vulkan_framebuffer.c @@ -2,12 +2,13 @@ #include "textures/vulkan_texture.h" #include "renderpass/vulkan_render_pass_descriptor.h" #include "output_device/vulkan_output_devices.h" +#include "vulkan_result_converter.h" gnReturnCode createFramebuffer(gnFramebuffer framebuffer, gnDevice device, gnFramebufferInfo info) { framebuffer->framebuffer = malloc(sizeof(struct gnPlatformFramebuffer_t)); VkImageView* attachments = malloc(sizeof(VkImageView) * info.attachmentCount); - for (int i = 0; i < info.attachmentCount; i++) + for (uint32_t i = 0; i < info.attachmentCount; i++) attachments[i] = info.attachments[i]->texture->image.imageView; VkFramebufferCreateInfo framebufferInfo = { @@ -22,7 +23,7 @@ gnReturnCode createFramebuffer(gnFramebuffer framebuffer, gnDevice device, gnFra VkResult res = vkCreateFramebuffer(device->outputDevice->device, &framebufferInfo, NULL, &framebuffer->framebuffer->framebuffer); free(attachments); - return GN_SUCCESS; + return VkResultToGnReturnCode(res); } void destroyFramebuffer(gnFramebuffer framebuffer) { diff --git a/projects/apis/vulkan/src/vulkan_surface/vulkan_surface.m b/projects/apis/vulkan/src/vulkan_surface/vulkan_surface.m index b4e9b4d..88b3832 100644 --- a/projects/apis/vulkan/src/vulkan_surface/vulkan_surface.m +++ b/projects/apis/vulkan/src/vulkan_surface/vulkan_surface.m @@ -13,11 +13,12 @@ #include "vulkan/vulkan_metal.h" gnReturnCode createMacOSWindowSurface(gnWindowSurfaceHandle windowSurface, gnInstanceHandle instance, gnMacOSWindowSurfaceInfo createInfo) { windowSurface->windowSurface = malloc(sizeof(gnPlatformWindowSurface)); - VkMetalSurfaceCreateInfoEXT surfaceCreateInfo = {}; - surfaceCreateInfo.sType = VK_STRUCTURE_TYPE_METAL_SURFACE_CREATE_INFO_EXT; - surfaceCreateInfo.pNext = NULL; - surfaceCreateInfo.flags = 0; - surfaceCreateInfo.pLayer = createInfo.layer; + VkMetalSurfaceCreateInfoEXT surfaceCreateInfo = { + .sType = VK_STRUCTURE_TYPE_METAL_SURFACE_CREATE_INFO_EXT, + .pNext = NULL, + .flags = 0, + .pLayer = createInfo.layer + }; return VkResultToGnReturnCode(vkCreateMetalSurfaceEXT(instance->instance->vk_instance, &surfaceCreateInfo, NULL, &windowSurface->windowSurface->surface)); } #endif